Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick(#29687): chore: fix docs roll for functions without args follow-up #29688

Merged
merged 2 commits into from
Feb 27, 2024
Merged

cherry-pick(#29687): chore: fix docs roll for functions without args follow-up #29688

merged 2 commits into from
Feb 27, 2024

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

@mxschmitt mxschmitt merged commit 8709a3a into release-1.42 Feb 27, 2024
90 of 97 checks passed
@mxschmitt mxschmitt deleted the cherry-pick-1.42-2024-02-27-15-51-44 branch February 27, 2024 15:52
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26584 passed, 613 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
9 failed
❌ [chromium] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
❌ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
❌ [firefox] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit] › library/browsercontext-viewport.spec.ts:94:3 › should not have touch by default
❌ [webkit] › library/capabilities.spec.ts:67:3 › should play video @smoke
❌ [webkit] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [webkit] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

83 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-events.spec.ts:19:5 › console event should work @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/elementhandle-wait-for-element-state.spec.ts:117:3 › should wait for stable position
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [firefox] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox] › library/browsercontext-timezone-id.spec.ts:98:3 › should affect Intl.DateTimeFormat().resolvedOptions().timeZone
⚠️ [firefox] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context
⚠️ [firefox] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/proxy.spec.ts:179:3 › should exclude patterns
⚠️ [chromium] › library/role-utils.spec.ts:37:7 › wpt accname #2
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-add-locator-handler.spec.ts:88:5 › should work with locator.hover()
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium] › library/selector-generator.spec.ts:414:5 › selector generator › should accept valid aria-label for candidate consideration
⚠️ [chromium] › library/trace-viewer.spec.ts:807:1 › should include requestUrl in route.fulfill
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-evaluate.spec.ts:333:3 › should properly serialize undefined fields
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:531:7 › cli codegen › should consume pointer events
⚠️ [webkit] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library/emulation-focus.spec.ts:190:12 › should trigger hover state concurrently
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:473:7 › cli codegen › should generate getByLabel
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:502:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [webkit] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [webkit] › library/browsercontext-viewport-mobile.spec.ts:57:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit] › library/browsercontext-viewport-mobile.spec.ts:66:5 › mobile viewport › should detect touch when applying viewport with touches
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit] › library/modernizr.spec.ts:33:3 › safari-14-1
⚠️ [webkit] › library/modernizr.spec.ts:82:3 › mobile-safari-14-1
⚠️ [webkit] › library/trace-viewer.spec.ts:755:1 › should open two trace files
⚠️ [webkit] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [webkit] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [webkit] › library/tracing.spec.ts:412:14 › should produce screencast frames scale

180772 passed, 8016 skipped, 1273 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@playwrightmachine @mxschmitt